Re: [PATCH v2 3/3] btrfs: Fix a C compliance issue

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bart,

I love your patch! Yet something to improve:

[auto build test ERROR on v4.18-rc1]
[also build test ERROR on next-20180620]
[cannot apply to btrfs/next]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Bart-Van-Assche/Three-patches-that-address-static-analyzer-reports/20180621-041247
config: m68k-sun3_defconfig (attached as .config)
compiler: m68k-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=m68k 

All errors (new ones prefixed by >>):

   fs//btrfs/super.c: In function 'btrfs_print_mod_info':
>> fs//btrfs/super.c:2386:4: error: expected expression before ';' token
       ;
       ^

vim +2386 fs//btrfs/super.c

  2370	
  2371	static void __init btrfs_print_mod_info(void)
  2372	{
  2373		static const char options[] =
  2374	#ifdef CONFIG_BTRFS_DEBUG
  2375				", debug=on"
  2376	#endif
  2377	#ifdef CONFIG_BTRFS_ASSERT
  2378				", assert=on"
  2379	#endif
  2380	#ifdef CONFIG_BTRFS_FS_CHECK_INTEGRITY
  2381				", integrity-checker=on"
  2382	#endif
  2383	#ifdef CONFIG_BTRFS_FS_REF_VERIFY
  2384				", ref-verify=on"
  2385	#endif
> 2386				;
  2387		pr_info("Btrfs loaded, crc32c=%s%s\n", crc32c_impl(), options);
  2388	}
  2389	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux