On 06/08/2018 08:43 AM, Misono Tomohiro wrote:
On 2018/06/07 21:22, David Sterba wrote:
On Thu, Jun 07, 2018 at 11:49:58AM +0900, Misono Tomohiro wrote:
Initialize all filed of btrfs_inode_item to zero in order to prevent
having some garbage, especially for flags field.
Have you observed in practice or is it a matter of precaution?
I saw failure of fsck-test/010 in yesterday's devel branch and
made this patch. It turned out that root cause was wrong flag comparison
in btrfs check.
(https://www.mail-archive.com/linux-btrfs@xxxxxxxxxxxxxxx/msg77758.html)
With Su's fix, failure of fsck-test/010 is also gone without this patch,
but it is better to initialize the variables anyway.
Agreed. I saw odd flags reported by btrfs check too.
The callers of insert_inode_item() don't set inode flags manully.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
