On Wed, May 02, 2018 at 03:19:32PM +0300, Nikolay Borisov wrote: > Currently this function handles both the READ and WRITE dio cases. This > is facilitated by a bunch of 'if' statements, a goto short-circuit > statement and a very perverse aliasing of "!created"(READ) case > by setting lockstart = lockend and checking for lockstart < lockend for > detecting the write. Let's simplify this mess by extracting the > READ-only code into a separate __btrfs_get_block_direct_read function. > This is only the first step, the next one will be to factor out the > write side as well. The end goal will be to have the common locking/ > unlocking code in btrfs_get_blocks_direct and then it will call either > the read|write subvariants. No functional changes. > > Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx> > --- > > V3: > * Add code to unlock unused portions of the file (if any) in the read case > * Improve the comment about the locking in !create case as well, making it > more explicit. 1 and 2 added to misc-next. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
