On Fri, May 18, 2018 at 01:10:59PM +0800, Qu Wenruo wrote: > > > On 2018年05月18日 13:02, Nikolay Borisov wrote: > > > > > > On 18.05.2018 05:59, Liu Bo wrote: > >> As verify_level_key() is checked after verify_parent_transid(), i.e. > >> > >> if (verify_parent_transid()) > >> ret = -EIO; > >> else if (verify_level_key()) > >> ret = -EUCLEAN; > >> > >> if parent_transid is 0, verify_parent_transid() skips verifying > >> parent_transid and considers eb as valid, and if verify_level_key() > >> reports something wrong, we're not going to know if it's caused by > >> corrupted metadata or non-checkecd eb (e.g. stale eb). > > > > It's really unclear (from the changelog) how the stale eb ties with > > parent_transid. You should have explained the relationship between > > checking parenttransid and stale/non-stale ebs > > It's in fact related to the fixing patch: > Btrfs: fix the corruption by reading stale btree blocks > > But whatever, extra mention won't hurt. I've added reference to the patch as it has more details so we don't have to repeat it in the changelog. Patch added to misc-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
