[josef-btrfs:blk-iolatency 8/13] mm/shmem.c:1222:10: error: implicit declaration of function 'mem_cgroup_try_charge_delay'; did you mean 'mem_cgroup_try_charge_swap'?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



tree:   https://git.kernel.org/pub/scm/linux/kernel/git/josef/btrfs-next.git blk-iolatency
head:   657e770d4d6e3b03c3d4b96e427b30d6f766e2e2
commit: 7f1e4ea0a7071711f43deaed15b123bcf0a3ee8f [8/13] blk-stat: export helpers for modifying blk_rq_stat
config: x86_64-randconfig-x011-201820 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        git checkout 7f1e4ea0a7071711f43deaed15b123bcf0a3ee8f
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   In file included from include/linux/blkdev.h:21:0,
                    from include/linux/backing-dev.h:15,
                    from mm/shmem.c:57:
   include/linux/bio.h:556:55: warning: 'struct blkcg_gq' declared inside parameter list will not be visible outside of this definition or declaration
    static int bio_associate_blkg(struct bio *bio, struct blkcg_gq *blkg) { return 0; }
                                                          ^~~~~~~~
   mm/shmem.c: In function 'shmem_unuse':
>> mm/shmem.c:1222:10: error: implicit declaration of function 'mem_cgroup_try_charge_delay'; did you mean 'mem_cgroup_try_charge_swap'? [-Werror=implicit-function-declaration]
     error = mem_cgroup_try_charge_delay(page, current->mm, GFP_KERNEL,
             ^~~~~~~~~~~~~~~~~~~~~~~~~~~
             mem_cgroup_try_charge_swap
   In file included from include/linux/backing-dev.h:17:0,
                    from mm/shmem.c:57:
   At top level:
   include/linux/blk-cgroup.h:832:13: warning: 'blkcg_schedule_throttle' defined but not used [-Wunused-function]
    static void blkcg_schedule_throttle(struct request_queue *q, bool use_memdelay) { }
                ^~~~~~~~~~~~~~~~~~~~~~~
   include/linux/blk-cgroup.h:831:13: warning: 'blkcg_add_delay' defined but not used [-Wunused-function]
    static void blkcg_add_delay(struct blkcg_gq *blkg, u64 now, u64 delta) { }
                ^~~~~~~~~~~~~~~
   In file included from include/linux/blkdev.h:21:0,
                    from include/linux/backing-dev.h:15,
                    from mm/shmem.c:57:
   include/linux/bio.h:556:12: warning: 'bio_associate_blkg' defined but not used [-Wunused-function]
    static int bio_associate_blkg(struct bio *bio, struct blkcg_gq *blkg) { return 0; }
               ^~~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors
--
   mm/memory.c: In function 'wp_page_copy':
>> mm/memory.c:2497:6: error: implicit declaration of function 'mem_cgroup_try_charge_delay'; did you mean 'mem_cgroup_try_charge_swap'? [-Werror=implicit-function-declaration]
     if (mem_cgroup_try_charge_delay(new_page, mm, GFP_KERNEL, &memcg, false))
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~
         mem_cgroup_try_charge_swap
   cc1: some warnings being treated as errors

vim +1222 mm/shmem.c

^1da177e Linus Torvalds     2005-04-16  1199  
^1da177e Linus Torvalds     2005-04-16  1200  /*
46f65ec1 Hugh Dickins       2011-08-03  1201   * Search through swapped inodes to find and replace swap by page.
^1da177e Linus Torvalds     2005-04-16  1202   */
41ffe5d5 Hugh Dickins       2011-08-03  1203  int shmem_unuse(swp_entry_t swap, struct page *page)
^1da177e Linus Torvalds     2005-04-16  1204  {
41ffe5d5 Hugh Dickins       2011-08-03  1205  	struct list_head *this, *next;
^1da177e Linus Torvalds     2005-04-16  1206  	struct shmem_inode_info *info;
00501b53 Johannes Weiner    2014-08-08  1207  	struct mem_cgroup *memcg;
bde05d1c Hugh Dickins       2012-05-29  1208  	int error = 0;
bde05d1c Hugh Dickins       2012-05-29  1209  
bde05d1c Hugh Dickins       2012-05-29  1210  	/*
bde05d1c Hugh Dickins       2012-05-29  1211  	 * There's a faint possibility that swap page was replaced before
0142ef6c Hugh Dickins       2012-06-07  1212  	 * caller locked it: caller will come back later with the right page.
bde05d1c Hugh Dickins       2012-05-29  1213  	 */
0142ef6c Hugh Dickins       2012-06-07  1214  	if (unlikely(!PageSwapCache(page) || page_private(page) != swap.val))
bde05d1c Hugh Dickins       2012-05-29  1215  		goto out;
778dd893 Hugh Dickins       2011-05-11  1216  
778dd893 Hugh Dickins       2011-05-11  1217  	/*
778dd893 Hugh Dickins       2011-05-11  1218  	 * Charge page using GFP_KERNEL while we can wait, before taking
778dd893 Hugh Dickins       2011-05-11  1219  	 * the shmem_swaplist_mutex which might hold up shmem_writepage().
778dd893 Hugh Dickins       2011-05-11  1220  	 * Charged back to the user (not to caller) when swap account is used.
778dd893 Hugh Dickins       2011-05-11  1221  	 */
90f955bb Tejun Heo          2018-04-16 @1222  	error = mem_cgroup_try_charge_delay(page, current->mm, GFP_KERNEL,
90f955bb Tejun Heo          2018-04-16  1223  					    &memcg, false);
778dd893 Hugh Dickins       2011-05-11  1224  	if (error)
778dd893 Hugh Dickins       2011-05-11  1225  		goto out;
46f65ec1 Hugh Dickins       2011-08-03  1226  	/* No radix_tree_preload: swap entry keeps a place for page in tree */
00501b53 Johannes Weiner    2014-08-08  1227  	error = -EAGAIN;
^1da177e Linus Torvalds     2005-04-16  1228  
cb5f7b9a Hugh Dickins       2008-02-04  1229  	mutex_lock(&shmem_swaplist_mutex);
41ffe5d5 Hugh Dickins       2011-08-03  1230  	list_for_each_safe(this, next, &shmem_swaplist) {
41ffe5d5 Hugh Dickins       2011-08-03  1231  		info = list_entry(this, struct shmem_inode_info, swaplist);
285b2c4f Hugh Dickins       2011-08-03  1232  		if (info->swapped)
00501b53 Johannes Weiner    2014-08-08  1233  			error = shmem_unuse_inode(info, swap, &page);
6922c0c7 Hugh Dickins       2011-08-03  1234  		else
6922c0c7 Hugh Dickins       2011-08-03  1235  			list_del_init(&info->swaplist);
cb5f7b9a Hugh Dickins       2008-02-04  1236  		cond_resched();
00501b53 Johannes Weiner    2014-08-08  1237  		if (error != -EAGAIN)
778dd893 Hugh Dickins       2011-05-11  1238  			break;
00501b53 Johannes Weiner    2014-08-08  1239  		/* found nothing in this: move on to search the next */
^1da177e Linus Torvalds     2005-04-16  1240  	}
cb5f7b9a Hugh Dickins       2008-02-04  1241  	mutex_unlock(&shmem_swaplist_mutex);
778dd893 Hugh Dickins       2011-05-11  1242  
00501b53 Johannes Weiner    2014-08-08  1243  	if (error) {
00501b53 Johannes Weiner    2014-08-08  1244  		if (error != -ENOMEM)
00501b53 Johannes Weiner    2014-08-08  1245  			error = 0;
f627c2f5 Kirill A. Shutemov 2016-01-15  1246  		mem_cgroup_cancel_charge(page, memcg, false);
00501b53 Johannes Weiner    2014-08-08  1247  	} else
f627c2f5 Kirill A. Shutemov 2016-01-15  1248  		mem_cgroup_commit_charge(page, memcg, true, false);
778dd893 Hugh Dickins       2011-05-11  1249  out:
aaa46865 Hugh Dickins       2009-12-14  1250  	unlock_page(page);
09cbfeaf Kirill A. Shutemov 2016-04-01  1251  	put_page(page);
778dd893 Hugh Dickins       2011-05-11  1252  	return error;
^1da177e Linus Torvalds     2005-04-16  1253  }
^1da177e Linus Torvalds     2005-04-16  1254  

:::::: The code at line 1222 was first introduced by commit
:::::: 90f955bbc57765617e3e99f784f3239c3d8f0360 memcontrol: schedule throttling if we are congested

:::::: TO: Tejun Heo <tj@xxxxxxxxxx>
:::::: CC: Josef Bacik <jbacik@xxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux