Re: [PATCH v3 1/3] btrfs: Move btrfs_check_super_valid() to avoid forward declaration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 25, 2018 at 12:24:10AM +0800, Anand Jain wrote:
> On misc-next this patch is causing regression, the seed sprout 
> functionality test [1] (in the mailing list) fails.

This patch merly moves the function so it must have been broken before
that already.

> > +	if (memcmp(fs_info->fsid, sb->dev_item.fsid, BTRFS_FSID_SIZE) != 0) {
> > +		btrfs_err(fs_info,
> > +			   "dev_item UUID does not match fsid: %pU != %pU",
> > +			   fs_info->fsid, sb->dev_item.fsid);
> > +		ret = -EINVAL;
> > +	}
> 
> 
> No. Not all devices will have the same fsid in case of seed-sprout
> mounted devices.

So we need to check if the filesystem has seeding enabled and then
compare the correct uuids, right?
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux