On 2018年05月18日 11:00, Liu Bo wrote: > The check is superfluous since all of callers who set search_for_commit > also have skip_locking set. > > Signed-off-by: Liu Bo <bo.liu@xxxxxxxxxxxxxxxxx> Reviewed-by: Qu Wenruo <wqu@xxxxxxxx> Although more obvious comment about search_commit_root and skip_locking in ctree.h will be much better. Thanks, Qu > --- > fs/btrfs/ctree.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/fs/btrfs/ctree.c b/fs/btrfs/ctree.c > index d12fc0474e21..8d3b09038f37 100644 > --- a/fs/btrfs/ctree.c > +++ b/fs/btrfs/ctree.c > @@ -2623,8 +2623,6 @@ static struct extent_buffer *btrfs_search_slot_get_root(struct btrfs_root *root, > level = btrfs_header_level(b); > if (p->need_commit_sem) > up_read(&fs_info->commit_root_sem); > - if (!p->skip_locking) > - btrfs_tree_read_lock(b); > > goto out; > } >
Attachment:
signature.asc
Description: OpenPGP digital signature
