On Wed, May 16, 2018 at 10:57:57AM +0300, Nikolay Borisov wrote: > On 16.05.2018 05:51, Anand Jain wrote: > > Balance args info is an important information to be reviewed for the > > system audit. So this patch adds it to the kernel log. > > > > Example: > > > > -> btrfs bal start -dprofiles='raid1|single',convert=raid5 -mprofiles='raid1|single',convert=raid5 /btrfs > > > > kernel: BTRFS info (device sdb): balance: start data profiles=raid1|single convert=raid5 metadata profiles=raid1|single convert=raid5 system profiles=raid1|single convert=raid5 > > > > -> btrfs bal start -dprofiles=raid5,convert=single -mprofiles='raid1|single',convert=raid5 --background /btrfs > > > > kernel: BTRFS info (device sdb): balance: start data profiles=raid5 convert=single metadata profiles=raid1|single convert=raid5 system profiles=raid1|single convert=raid5 > > > > Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx> > > Why can't this code be part of progs, the bctl which you are parsing is > constructed from the arguments passed from users space? I think you are > adding way too much string parsing code to the kernel and this is never > a good sign, since it's very easy to trip. progs are not the only way to start a balance, they're merely the most widespread one. For example, Hans van Kranenburg has some smarter scripts among his tools -- currently only of "example" quality, but quite useful already. "balance_least_used" works in greedy order (least used first) with nice verbose output. It's not unlikely he or someone else improves this further. Thus, I really think the logging should be kernel side. On the other hand, the string producing (not parsing) code is so repetitive that it indeed could use some refactoring. Meow! -- ⢀⣴⠾⠻⢶⣦⠀ ⣾⠁⢰⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ Certified airhead; got the CT scan to prove that! ⠈⠳⣄⠀⠀⠀⠀ -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
