On 15.05.2018 11:48, Qu Wenruo wrote:
<SNIP>
>>>>
>>>>
>>>> static inline int inode_need_compress(struct inode *inode, u64 start, u64 end)
>>>> {
>>>> struct btrfs_fs_info *fs_info =trfs_sb(inode->i_sb);
>>>>
>>>> /* defrag ioctl */
>>>> if (BTRFS_I(inode)->defrag_compress)
>>>> return 1;
>>>> /* bad compression ratios */
>>>> if (BTRFS_I(inode)->flags & BTRFS_INODE_NOCOMPRESS)
>>>> return 0;
>>>
>>> Not exactly.
>>> Force-compress should less us bypass bad compression ratio, so it should
>>> be at least before ratio check.
Fair enough, what prompted me in suggesting this is that perhaps the
check for BTRFS_INODE_NOCOMPRESS should be somwhere at the top of the
function (alongside the newly added two checks for inode flags), no ?
INODE_NOCOMPRESS can be set via icotl not necessarily only due to bad
compression ratio.
>>>
>>> Thanks,
>>> Qu
>>>
>>>> /* force compress */
>>>> if (btrfs_test_opt(fs_info, FORCE_COMPRESS))
>>>> return 1;
>>>> if (btrfs_test_opt(fs_info, COMPRESS) ||
>>>> BTRFS_I(inode)->flags & BTRFS_INODE_COMPRESS ||
>>>> BTRFS_I(inode)->prop_compress)
>>>> return btrfs_compress_heuristic(inode, start, end);
>>>> return 0;
>>>> }
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
