Re: [PATCH v3 0/3] btrfs: Add write time super block validation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 11, 2018 at 01:35:24PM +0800, Qu Wenruo wrote:
> This patchset can be fetched from github:
> https://github.com/adam900710/linux/tree/write_time_sb_check
> 
> We have 2 reports about corrupted btrfs super block, which has some garbage
> in its super block, but otherwise it's completely fine and its csum even
> matches.
> 
> This means we develop memory corruption during btrfs mount time.
> It's not clear whether it's caused by btrfs or some other kernel module,
> but at least let's do write time verification to catch such corruption
> early.
> 
> Current design is to do 2 different checks at mount time and super write
> time.
> And for write time check, it only checks the template super block
> (fs_info->super_to_commit) other than each super blocks to be written to
> disk, mostly to avoid duplicated checks.
> 
> Changelog:
> v2:
>   Rename btrfs_check_super_valid() to btrfs_validate_super() suggested
>   by Nikolay and David.
> v3:
>   Add a new patch to move btrfs_check_super_valid() to avoid forward
>   declaration.
>   Refactor btrfs_check_super_valid() to provide better naming and
>   function reusablity.
>   Code style and comment update.
>   Use 2 different functions, btrfs_validate_mount_super() and
>   btrfs_validate_write_super(), for mount and write time super check.

Added as topic branch to next, I'm still targeting 4.18 with this
patchset so it'll end up in misc-next after some testing. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux