Re: [PATCH 1/2] btrfs-progs: print-tree: Avoid segfault for heavily corrupted item pointers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 07, 2018 at 04:56:21PM +0800, Qu Wenruo wrote:
> 
> 
> On 2018年05月07日 15:46, Qu Wenruo wrote:
> > Normally corrupted leaf should be caught by csum check, but sometimes
> > corrupted item pointers (out of leaf range) can still pass csum check.
> > In fact, our fsck/005 test case image has such corrupted item pointer
> > and btrfs check can surprisingly fix it.
> > 
> > Anyway, make print-tree to skip such item and remaining slots to avoid
> > segfault.
> > 
> > Please note that, in btrfs-progs we can't put such check into
> > check_tree_block() nor do kernel level comprehensive check as under
> > certain case, btrfs-progs can handle or even repair it.
> > A restrict check_tree_block() or backporting kernel btrfs_check_leaf()
> > could break such test cases and reduce the utility of btrfs-progs.
> > 
> > Issue: #128
> > Reported-by: Hubert Kario <kario@xxxxxxxxxx>
> 
> Mail changed to <hubert@xxxxxxxx> (Github version already updated.)

Updated and applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux