On Fri, Apr 27, 2018 at 01:36:35PM +0800, Liu Bo wrote:
> > What does btrfs_search_forward do as the first statement:
> >
> > 5115 int btrfs_search_forward(struct btrfs_root *root, struct btrfs_key *min_key,
> > 5116 struct btrfs_path *path,
> > 5117 u64 min_trans)
> > 5118 {
> > .... declarations
> > 5128
> > 5129 path->keep_locks = 1;
> >
> > So even if removed from above, there will be no change. The value of
> > keep_locks is preserved after btrfs_path_release.
> >
>
> FYI, btrfs_search_forward() doesn't need keep_locks's semantics as all
> of its callers only access path->nodes[0], thus I'm planning to remove
> keep_locks setting inside it, too.
Ok.
Please update the changelog of this patch and note something about
btrfs_search_forward that sets the path lock on it's own and that
there's no change in defrag leaves.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
