Re: [PATCH v2] btrfs: fix BUG trying to resume balance without resume flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Anand,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on btrfs/next]
[also build test ERROR on v4.17-rc3 next-20180430]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Anand-Jain/btrfs-fix-BUG-trying-to-resume-balance-without-resume-flag/20180430-192532
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mason/linux-btrfs.git next
config: i386-randconfig-x000-201817 (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   fs//btrfs/volumes.c: In function 'btrfs_resume_balance_async':
>> fs//btrfs/volumes.c:3971:24: error: 'struct btrfs_balance_control' has no member named 'b_flags'; did you mean 'flags'?
     fs_info->balance_ctl->b_flags |= BTRFS_BALANCE_RESUME;
                           ^~~~~~~
                           flags

vim +3971 fs//btrfs/volumes.c

  3954	
  3955	int btrfs_resume_balance_async(struct btrfs_fs_info *fs_info)
  3956	{
  3957		struct task_struct *tsk;
  3958	
  3959		spin_lock(&fs_info->balance_lock);
  3960		if (!fs_info->balance_ctl) {
  3961			spin_unlock(&fs_info->balance_lock);
  3962			return 0;
  3963		}
  3964		spin_unlock(&fs_info->balance_lock);
  3965	
  3966		if (btrfs_test_opt(fs_info, SKIP_BALANCE)) {
  3967			btrfs_info(fs_info, "force skipping balance");
  3968			return 0;
  3969		}
  3970	
> 3971		fs_info->balance_ctl->b_flags |= BTRFS_BALANCE_RESUME;
  3972	
  3973		tsk = kthread_run(balance_kthread, fs_info, "btrfs-balance");
  3974		return PTR_ERR_OR_ZERO(tsk);
  3975	}
  3976	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux