On Tue, Apr 24, 2018 at 12:48:07PM +0800, Qu Wenruo wrote: > Although we have already checked incompat flags manually before really > mounting it, we could still enhance btrfs_check_super_valid() to check > incompat flags for later write time super block validation check. But the calls are in reverse. First the validation is called and then the incompat bits are verified if the filesystem is mountable. With change in this patch, any uknonwn incompat bit at mount time will be reported as corruption. This does not make sense. I've read the discussion under previous version again, IMHO the best way to report what's going on is to use 2 functions for mount ant pre-commit time. We can't expect that random user will understand that new unsupported flags actually mean corruption or that unsupported bits at mount time are not really a corruption. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
