On Fri, Apr 20, 2018 at 10:07:17AM +0300, Nikolay Borisov wrote: > > > On 19.04.2018 19:33, David Sterba wrote: > > + /* reset_balance_state needs volume_mutex */ > > Does it make sense to codify this invariant as lockdep_assert_held in > reset_balance_state ? No, the comment and the mutex will be removed in the following patches. But yeah in general the lockdep annotations are better than the comments stating which lock is supposed to be held. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
