On Wed, Apr 11, 2018 at 03:47:35PM +0800, Qu Wenruo wrote: > >>>> What about using lvm other than plain dmsetup to create thin provision > >>>> devices? > >>>> IIRC this should be much easier to implement, without all the linear > >>>> target hassles. > >>> > >>> Yes, doing it by LVM is more convenient. > >>> However, LVM seems too abstract and it's never used in btrfs-progs. > >>> > >>> I have no idea whether LVM other tools should be used or not. > >> > >> We have check_global_prereq(), so it's no a problem to use external tools. > > > > IMHO it's a good idea to keep requirements to the bare minimum. While > > LVM will indeed be more user (in this case developer) friendly, I think > > it's abstracting too much. So I'd rather stick with plain dm-setup. > > Well, when we using device mappers, we're already introducing a lot of > requirement, like kernel dm targets. > > IMHO, if we can make test case shorter, it would help both test case > developer and later developer who exposes problem on this test case. > So I still prefer to use LVM to make test case smaller and easier to > understand. (even this means extra infrastructures) I think using dmsetup is still ok, the complexity can be factored out to helpers if we need that again. We already use dmsetup so there's no change necessary in the testing environment. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
