On Mon, Mar 19, 2018 at 04:27:09PM +0900, Misono, Tomohiro wrote: > changelog: > > v2-> v3 > - fix kbuild test bot warning > v1 -> v2 > - completely reimplement 1st/2nd ioctl to have user friendly api > - various cleanup, remove unnecessary goto > === > > This adds three new unprivileged ioctls: > > 1st patch: ioctl which returns subvolume information of ROOT_ITEM and ROOT_BACKREF > 2nd patch: ioctl which returns subvolume information of ROOT_REF (without subvolume name) > 3rd patch: user version of ino_lookup ioctl which also peforms permission check. The overall approach to listing subvolumes looks good. We can enumerate them, get the relations and the details. Making some sense of that in the userspace is a whole different and maybe more difficult topic. I hope we could use the opportunity to clean up the listing commandline interface and output at the same time, as there's going to be possibly some incompatibility introduced. We need to start with current usecases and how they're implemented or mis-implemented (ie. leading to confusion). The discussions I've read so far cover a good part of that. I'll review and add the kernel patches to misc-next to get some testing coverage. As this is a non-restricted ioctl full of pointers and bytes shuffled around, we will have to do an extra security-oriented review. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
