On Mon, Apr 09, 2018 at 10:29:34PM +0800, Qu Wenruo wrote: > >> --- a/cmds-inspect-dump-tree.c > >> +++ b/cmds-inspect-dump-tree.c > >> @@ -303,7 +303,9 @@ int cmd_inspect_dump_tree(int argc, char **argv) > >> int uuid_tree_only = 0; > >> int roots_only = 0; > >> int root_backups = 0; > >> - unsigned open_ctree_flags = OPEN_CTREE_FS_PARTIAL; > >> + /* Speed up open_ctree() and continue if extent tree is corrupted */ > >> + unsigned open_ctree_flags = OPEN_CTREE_PARTIAL | > >> + OPEN_CTREE_NO_BLOCK_GROUPS; > > > > We could consider that separatelly, whether to allow dumping a partially > > created filesystem, ie. OPEN_CTREE_FS_PARTIAL added by a new option. > > For dump-tree, there is really no limitation here. > As long as chunk tree is OK, we should be OK to do "-b" dump. > > For "-t" or all tree (default) dump, with chunk tree opened only, we > could try our best to print any good trees. > So I don't get the point to read all other trees. Yeah, eg. a bad filesystem magic number does not stop dump-tree, so no change is needed. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
