On 03/27/2018 03:19 PM, Nikolay Borisov wrote:
A bunch of functions in lowmem mode take an 'ext_ref' parameter only to pass it down the call chain where it eventually is consumed. Turns out the functions which actually check the parameter are find_inode_ref and check_inode_item, the are only passing it down to them. At the same time those functions can get a reference to fs_info and do the check in them at the appropriate time. This patchset cleanups the interface of various function by dropping the ext_ref argument and moving the actual query of the EXTREF feature closer to where it's being used. The final patch just changes signature of __btrfs_fs_incompat to better match the logic of the code and be identical to its kernel counterpart. All in all this series doesn't introduce any functional changes per-se. Nikolay Borisov (10): btrfs-progs: Drop ext_ref parameter from find_inode_ref btrfs-progs: Drop ext_ref param from check_dir_item btrfs-progs: Drop ext_ref argument from check_inode_item btrfs-progs: Drop unused ext_ref parameter from process_one_leaf btrfs-progs: Remove ext_ref param from check_fs_first_inode btrfs-progs: Remove ext_ref param from walk_down_tree btrfs-progs: Drop ext_ref param from check_fs_first_inode btrfs-progs: Drop ext_ref arument from check_fs_root btrfs-progs: Remove ext_ref local variable from check_fs_roots_lowmem btrfs-progs: Make __btrfs_fs_incompat return bool
Nice work. For all, Reviewed-by: Su Yue <suy.fnst@xxxxxxxxxxxxxx>
check/mode-lowmem.c | 63 +++++++++++++++++++++++------------------------------ ctree.h | 2 +- 2 files changed, 28 insertions(+), 37 deletions(-)
-- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
