Re: [PATCH 2/3] btrfs-progs: Remove deprecated btrfs-show-super

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2018年03月22日 21:18, Nikolay Borisov wrote:
> Its function has been superseded by btrfs inspect-internal show-super.
> Furthermore the tools is currently not built by default. Just remove
> it.

Same missing sob tag.

> ---
>  Makefile           |  2 +-
>  btrfs-show-super.c | 39 ---------------------------------------

And it would be better to update
Documentation/btrfs-select-super.asciidoc which refers to this
deprecated tool.

Thanks,
Qu

>  2 files changed, 1 insertion(+), 40 deletions(-)
>  delete mode 100644 btrfs-show-super.c
> 
> diff --git a/Makefile b/Makefile
> index 2a2a76855a26..087289b756ef 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -215,7 +215,7 @@ progs_install = btrfs mkfs.btrfs btrfs-map-logical btrfs-image \
>  	btrfs-select-super
>  
>  # other tools, not built by default
> -progs_extra = btrfs-fragments btrfs-calc-size btrfs-show-super
> +progs_extra = btrfs-fragments btrfs-calc-size
>  
>  progs_static = $(foreach p,$(progs),$(p).static)
>  
> diff --git a/btrfs-show-super.c b/btrfs-show-super.c
> deleted file mode 100644
> index 4273e42dca3d..000000000000
> --- a/btrfs-show-super.c
> +++ /dev/null
> @@ -1,39 +0,0 @@
> -/*
> - * Copyright (C) 2012 STRATO AG.  All rights reserved.
> - *
> - * This program is free software; you can redistribute it and/or
> - * modify it under the terms of the GNU General Public
> - * License v2 as published by the Free Software Foundation.
> - *
> - * This program is distributed in the hope that it will be useful,
> - * but WITHOUT ANY WARRANTY; without even the implied warranty of
> - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
> - * General Public License for more details.
> - *
> - * You should have received a copy of the GNU General Public
> - * License along with this program; if not, write to the
> - * Free Software Foundation, Inc., 59 Temple Place - Suite 330,
> - * Boston, MA 021110-1307, USA.
> - */
> -
> -#include "utils.h"
> -#include "commands.h"
> -#include "help.h"
> -
> -int main(int argc, char **argv)
> -{
> -
> -	int ret;
> -
> -	set_argv0(argv);
> -
> -	warning(
> -"\nthe tool has been deprecated, please use 'btrfs inspect-internal dump-super' instead\n");
> -
> -	if (argc > 1 && !strcmp(argv[1], "--help"))
> -		usage(cmd_inspect_dump_super_usage);
> -
> -	ret = cmd_inspect_dump_super(argc, argv);
> -
> -	return ret;
> -}
> 

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux