On Tue, Mar 13, 2018 at 11:03:31PM +0800, Anand Jain wrote: > On 03/08/2018 10:33 PM, David Sterba wrote: > > All callers pass a valid pointer, we can remove the redundant checks. > > > > Signed-off-by: David Sterba <dsterba@xxxxxxxx> > > --- > > fs/btrfs/extent_io.c | 9 ++++++--- > > 1 file changed, 6 insertions(+), 3 deletions(-) > > > > diff --git a/fs/btrfs/extent_io.c b/fs/btrfs/extent_io.c > > index d00d5a59ff21..36514baa661e 100644 > > --- a/fs/btrfs/extent_io.c > > +++ b/fs/btrfs/extent_io.c > > @@ -2875,6 +2875,8 @@ __get_extent_map(struct inode *inode, struct page *page, size_t pg_offset, > > * handlers) > > * XXX JDM: This needs looking at to ensure proper page locking > > * return 0 on success, otherwise return error > > + * > > + * @prev_em_start: return value of previous em start value; must be valid > > */ > > static int __do_readpage(struct extent_io_tree *tree, > > struct page *page, > > @@ -2903,6 +2905,8 @@ static int __do_readpage(struct extent_io_tree *tree, > > size_t blocksize = inode->i_sb->s_blocksize; > > unsigned long this_bio_flag = 0; > > > > + ASSERT(prev_em_start); > > + > > > mount is failing with this patch as in this stack below the > prev_em_start is NULL. Right, I've removed the patch. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
