On 3/8/18 12:33 AM, Qu Wenruo wrote: > > > On 2018年03月08日 10:40, jeffm@xxxxxxxx wrote: >> From: Jeff Mahoney <jeffm@xxxxxxxx> >> >> The btrfs qgroup show command currently only exports qgroup IDs, >> forcing the user to resolve which subvolume each corresponds to. >> >> This patch adds pathname resolution to qgroup show so that when >> the -P option is used, the last column contains the pathname of >> the root of the subvolume it describes. In the case of nested >> qgroups, it will show the number of member qgroups or the paths >> of the members if the -v option is used. >> >> Pathname can also be used as a sort parameter. >> >> Signed-off-by: Jeff Mahoney <jeffm@xxxxxxxx> > > Reviewed-by: Qu Wenruo <wqu@xxxxxxxx> > > Except one nitpick inlined below. > > [snip] >> } >> + if (bq->pathname) >> + free((void *)bq->pathname); > > What about just free(bq->pathname);? > > Is this (void *) used to get around the const prefix? Yes. Thanks, -Jeff -- Jeff Mahoney SUSE Labs
Attachment:
signature.asc
Description: OpenPGP digital signature
