Re: [PATCH 3/4] btrfs-progs: check/lowmem mode: Check inline extent size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 03/01/2018 10:47 AM, Qu Wenruo wrote:
Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>

Looks good to me.

Reviewed-by: Su Yue <suy.fnst@xxxxxxxxxxxxxx>
---
  check/mode-lowmem.c | 8 ++++++++
  1 file changed, 8 insertions(+)

diff --git a/check/mode-lowmem.c b/check/mode-lowmem.c
index 62bcf3d2e126..44c58163f8f7 100644
--- a/check/mode-lowmem.c
+++ b/check/mode-lowmem.c
@@ -1417,6 +1417,7 @@ static int check_file_extent(struct btrfs_root *root, struct btrfs_key *fkey,
  	u64 csum_found;		/* In byte size, sectorsize aligned */
  	u64 search_start;	/* Logical range start we search for csum */
  	u64 search_len;		/* Logical range len we search for csum */
+	u32 max_inline_extent_size = BTRFS_MAX_INLINE_DATA_SIZE(root->fs_info);
  	unsigned int extent_type;
  	unsigned int is_hole;
  	int compressed = 0;
@@ -1440,6 +1441,13 @@ static int check_file_extent(struct btrfs_root *root, struct btrfs_key *fkey,
  				root->objectid, fkey->objectid, fkey->offset);
  			err |= FILE_EXTENT_ERROR;
  		}
+		if (extent_num_bytes > max_inline_extent_size) {
+			error(
+		"root %llu EXTENT_DATA[%llu %llu] too large inline extent size, have %llu, max: %u",
+				root->objectid, fkey->objectid, fkey->offset,
+				extent_num_bytes, max_inline_extent_size);
+			err |= FILE_EXTENT_ERROR;
+		}
  		if (!compressed && extent_num_bytes != item_inline_len) {
  			error(
  		"root %llu EXTENT_DATA[%llu %llu] wrong inline size, have: %llu, expected: %u",



--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux