We aren't verifying the parameter passed to the max_inline mount option.
So we won't fail the mount if a junk value is specified, for example,
-o max_inline=abc. This patch checks if input is valid.
Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
---
v2->v3: Handle parameter with unit, such as 4K. Use memparse() 2nd arg.
v1->v2: use match_int ret value if error
use %u instead of %d for parser
fs/btrfs/super.c | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/fs/btrfs/super.c b/fs/btrfs/super.c
index 77e0537e1db5..76b58da8d56d 100644
--- a/fs/btrfs/super.c
+++ b/fs/btrfs/super.c
@@ -605,7 +605,14 @@ int btrfs_parse_options(struct btrfs_fs_info *info, char *options,
case Opt_max_inline:
num = match_strdup(&args[0]);
if (num) {
- info->max_inline = memparse(num, NULL);
+ char *retptr;
+
+ info->max_inline = memparse(num, &retptr);
+ if (*retptr != '\0') {
+ ret = -EINVAL;
+ kfree(num);
+ goto out;
+ }
kfree(num);
if (info->max_inline) {
--
2.15.0
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
