Re: [PATCH] btrfs: Move error handling of btrfs_start_dirty_block_groups closer to call site

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 09, 2018 at 11:30:18AM +0200, Nikolay Borisov wrote:
> Even though btrfs_start_dirty_block_groups fairly in the beginning of
> btrfs_commit_transaction outside of the critical section defined by the
> transaction states it can only be run by a single comitter. In other
> words it defines its own critical section thanks to the
> BTRFS_TRANS_DIRTY_BG run flag and ro_block_group_mutex. However, its
> error handling is outside of this critical section which is a bit
> counter-intuitive. So move the error handling righ after the function
> is executed and let the sole runner of dirty block groups handle the
> return value. no functional changes
> 
> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux