Re: [PATCH] btrfs: fix extent_buffer_uptodate() return

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 12, 2018 at 11:34:56PM +0800, Anand Jain wrote:
> extent_buffer_uptodate() returns from test_bit() which is of
> type bool, so update extent_buffer_uptodate() to it.

The return value of test_bit differes by architecture, there are several
that return int. You probably refer to x86 that uses some trickery to
optimize for constants and that returns bool. While we can add more
int/bool, I don't think it's wrong to have int here so I don't see what
this patch fixes.

In this particular case, extent_buffer_uptodate is a trivial wrapper
around test_bit so it would be better to make it a static inline. This
would remove the call indirection and reduce size of the code.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux