Re: [PATCH v2] btrfs: handle failure of add_pending_csums

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 26, 2018 at 09:28:58AM -0500, Josef Bacik wrote:
> On Mon, Jan 08, 2018 at 10:59:43AM +0200, Nikolay Borisov wrote:
> > add_pending_csums was added as part of the new data=ordered implementation in
> > e6dcd2dc9c48 ("Btrfs: New data=ordered implementation"). Even back then it
> > called the btrfs_csum_file_blocks which can fail but it never bothered handling
> > the failure. In ENOMEM situation this could lead to the filesystem failing to
> > write the checksums for a particular extent and not detect this. On read this
> > could lead to the filesystem erroring out due to crc mismatch. Fix it by
> > propagating failure from add_pending_csums and handling them
> > 
> > Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>
> 
> Reviewed-by: Josef Bacik <jbacik@xxxxxx>

Reviewed-by: David Sterba <dsterba@xxxxxxxx>

and added to next, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux