RE: [RFC PATCH v2 3/4] btrfs-progs: Modify rootdir files when use mkfs.btrfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: David Sterba [mailto:dsterba@xxxxxxx]
> Sent: Saturday, February 03, 2018 2:11 AM
> To: Gu, Jinxiang/顾 金香 <gujx@xxxxxxxxxxxxxx>
> Cc: linux-btrfs@xxxxxxxxxxxxxxx; dsterba@xxxxxxx; quwenruo.btrfs@xxxxxxx
> Subject: Re: [RFC PATCH v2 3/4] btrfs-progs: Modify rootdir files when use mkfs.btrfs
> 
> On Fri, Feb 02, 2018 at 04:34:04PM +0800, Gu Jinxiang wrote:
> > Since there is no $TOP/Documentation file after package the testsuite.
> > So use a common file that is usually exsits.
> >
> > Signed-off-by: Gu Jinxiang <gujx@xxxxxxxxxxxxxx>
> > ---
> >  tests/misc-tests/002-uuid-rewrite/test.sh       | 4 ++--
> >  tests/misc-tests/003-zero-log/test.sh           | 2 +-
> >  tests/mkfs-tests/004-rootdir-keeps-size/test.sh | 2 +-
> >  3 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/tests/misc-tests/002-uuid-rewrite/test.sh
> > b/tests/misc-tests/002-uuid-rewrite/test.sh
> > index 158bda90..27341322 100755
> > --- a/tests/misc-tests/002-uuid-rewrite/test.sh
> > +++ b/tests/misc-tests/002-uuid-rewrite/test.sh
> > @@ -25,7 +25,7 @@ test_uuid_random()
> >
> >  	run_check $SUDO_HELPER $EXEC/mkfs.btrfs -f \
> >  		--uuid $origuuid \
> > -		--rootdir $TOP/Documentation \
> > +		--rootdir /lib/modules/`uname -r`/ \
> 
> As an easy source of filesystem data it's ok, maybe in the log term something more deterministic should be implemented. The size of the
> modules is unpredictable and may not fit on the filesystem and the test would fail.
> 
> The size of the Documentation/ is 388KiB on my system, the modules are
> +260MiB, that also makes the test run longer for no reason.
> 
I'll add Documentation into the list which will be add to tarball.
And revert this patch.


?韬{.n?????%??檩??w?{.n???{饼?~镶?^n?■???h?璀?{?夸z罐?+€?zf"?????i?????_璁?:+v??撸?





[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux