On 2.02.2018 13:49, Qu Wenruo wrote:
>
>
> On 2018年02月02日 19:41, Nikolay Borisov wrote:
>>
>>
>> On 2.02.2018 10:19, Qu Wenruo wrote:
>>> Just as kernel find_free_dev_extent(), allow it to return maximum hole
>>> size for us to build device list for later chunk allocator rework.
>>>
>>> Signed-off-by: Qu Wenruo <wqu@xxxxxxxx>
>>> ---
>>> volumes.c | 6 +++---
>>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/volumes.c b/volumes.c
>>> index b47ff1f392b5..f4009ffa7c9e 100644
>>> --- a/volumes.c
>>> +++ b/volumes.c
>>> @@ -516,10 +516,10 @@ out:
>>> }
>>>
>>> static int find_free_dev_extent(struct btrfs_device *device, u64 num_bytes,
>>> - u64 *start)
>>> + u64 *start, u64 *len)
>>> {
>>> /* FIXME use last free of some kind */
>>> - return find_free_dev_extent_start(device, num_bytes, 0, start, NULL);
>>> + return find_free_dev_extent_start(device, num_bytes, 0, start, len);
>>
>> Why do we need the free_dev_extent() wrapper over free_dev_extent_start
>> at all?
>
> Because kernel part still needs find_free_dev_extent(), in extent-tree.c.
>
> I'd prefer to keep the function across kernel and btrfs-progs.
You are right, I missed it while I was grepping the first time.
Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>
>
> Thanks,
> Qu
>
>>> }
>>>
>>> static int btrfs_alloc_dev_extent(struct btrfs_trans_handle *trans,
>>> @@ -543,7 +543,7 @@ static int btrfs_alloc_dev_extent(struct btrfs_trans_handle *trans,
>>> * is responsible to make sure it's free.
>>> */
>>> if (!convert) {
>>> - ret = find_free_dev_extent(device, num_bytes, start);
>>> + ret = find_free_dev_extent(device, num_bytes, start, NULL);
>>> if (ret)
>>> goto err;
>>> }
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
>> the body of a message to majordomo@xxxxxxxxxxxxxxx
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
