On 2018年01月26日 15:25, Gu Jinxiang wrote: > Patch 1~4 and 7: clean up use of btrfs_root. > Patch 5: remove redundancy value assignment. > Patch 6: remove no longer be used function define. Overall it looks good, just one small nitpick, which should not need another update. > Changelog: > v2->v1: > Patch 2,4: To be consistent with kernel, change macro to inline function. > Patch 3: > Change macro to inline function to be consistent with kernel. > And change the function body to match kernel. > > Gu Jinxiang (7): > btrfs-progs: Use fs_info instead of root for BTRFS_LEAF_DATA_SIZE > btrfs-progs: Use fs_info instead of root for BTRFS_NODEPTRS_PER_BLOCK > btrfs-progs: Use fs_info instead of root for > BTRFS_MAX_INLINE_DATA_SIZE Not only this patch modified the parameter but also sync the code with kernel. It would be better to mention it in commit message, but anyway, just a small nitpick, nothing to worry about. Reviewed-by: Qu Wenruo <wqu@xxxxxxxx> Thanks, Qu > btrfs-progs: Use fs_info instead of root for BTRFS_MAX_XATTR_SIZE > btrfs-progs: do clean up for redundancy value assignment > btrfs-progs: remove no longer be used btrfs_alloc_extent > btrfs-progs: Cleanup use of root in leaf_data_end > > cmds-check.c | 10 ++--- > convert/source-ext2.c | 4 +- > convert/source-reiserfs.c | 6 +-- > ctree.c | 96 +++++++++++++++++++++++++---------------------- > ctree.h | 45 +++++++++++++--------- > dir-item.c | 3 +- > extent-tree.c | 1 - > file-item.c | 2 +- > mkfs/main.c | 4 +- > print-tree.c | 2 +- > quick-test.c | 2 +- > volumes.c | 2 +- > 12 files changed, 97 insertions(+), 80 deletions(-) >
Attachment:
signature.asc
Description: OpenPGP digital signature
