Re: [PATCH] btrfs-progs: ins: fix arg order in print_inode_item()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

Would you please queue this patch to devel branch?

This is a small enough, but quite important fix when handling dump tree
output.

Thanks,
Qu

On 2017年10月30日 16:20, Qu Wenruo wrote:
> 
> 
> On 2017年10月30日 16:10, Misono, Tomohiro wrote:
>> In the print_inode_item(), the argument order of sequence and flags are
>> reversed:
>>
>> printf("... sequence %llu flags 0x%llx(%s)\n",
>> 				... 
>> 	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
>> 				...)
>>
>> So, just fix it.
>>
>> Signed-off-by: Tomohiro Misono <misono.tomohiro@xxxxxxxxxxxxxx>
> 
> Reviewed-by: Qu Wenruo <wqu@xxxxxxxx>
> 
> Thanks,
> Qu
> 
>> ---
>>  print-tree.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/print-tree.c b/print-tree.c
>> index 3c585e3..8abd760 100644
>> --- a/print-tree.c
>> +++ b/print-tree.c
>> @@ -896,8 +896,8 @@ static void print_inode_item(struct extent_buffer *eb,
>>  	       btrfs_inode_uid(eb, ii),
>>  	       btrfs_inode_gid(eb, ii),
>>  	       (unsigned long long)btrfs_inode_rdev(eb,ii),
>> -	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
>> +	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       flags_str);
>>  	print_timespec(eb, btrfs_inode_atime(ii), "\t\tatime ", "\n");
>>  	print_timespec(eb, btrfs_inode_ctime(ii), "\t\tctime ", "\n");
>>
> 

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux