On Tue, Dec 19, 2017 at 11:36:58AM -0800, Omar Sandoval wrote: > On Tue, Dec 19, 2017 at 09:19:10PM +0200, Nikolay Borisov wrote: > > > > > > On 19.12.2017 21:01, Omar Sandoval wrote: > > > My only objection is that we shouldn't rename the field names in the > > > UAPI header. Let's just add a comment that the two counters are ignored. > > > Besides that, > > > > Why is that? > > We don't know if anyone is including the UAPI header and referring to > these fields for whatever reason. A quick Google search doesn't turn up > anything, but it has been there forever so I think we should err on the > side of not breaking the API. At least snapper sets these: https://github.com/openSUSE/snapper/blob/3c126c92bf2bd25a952800b2efb18754148ac227/snapper/BtrfsUtils.cc#L147 They get it from the libbtrfs header, but we might some day sync it to the UAPI header. So it's not completely theoretical :) -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
