On 15.12.2017 13:36, Qu Wenruo wrote: > . > > But btrfs_space_reservation() seems to be abused. > Every type from delalloc to enospc debug will use it. > > What about splitting them into different trace events? I think trace events form some sort of an ABI so we can't really be modifying current events, though I'd defer to David on that matter. OTOH the trace event contains all the information we like - either if it's an alloc/free operation, whether it's data or metadata and whether it's enospc or not. Admittedly the last thing is a bit of a pain-point since if you want to filter enospc you have to do string parsing on the output from the trace_btrfs_space_reservation. But even this doesn't sound too compelling to warrant a split. Either ways I'm fine with it. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
