Re: [PATCH 1/7] btrfs-progs: Explictly state test.sh must be executable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2017年12月05日 16:39, Nikolay Borisov wrote:
> Signed-off-by: Nikolay Borisov <nborisov@xxxxxxxx>
> ---
>  tests/README.md | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/README.md b/tests/README.md
> index 04d2ce2ab40d..c456018554cc 100644
> --- a/tests/README.md
> +++ b/tests/README.md
> @@ -164,7 +164,9 @@ how to do mkfs, mount, unmount, check, etc.
>  and join by dashes `-`. This will become the directory name, eg. `012-subvolume-sync-must-wait`.
>  
>  3. Write a short description of the bug and how it's tested to the comment at the
> -begining of `test.sh`. You don't need to add the file to git yet.
> +begining of `test.sh`. You don't need to add the file to git yet. Don't forget
> +to make the file executable, otherwise it's not going to be executed by the
> +infrastructure.

This comment is really needed, as myself also sometimes forget to do that.

Reviewed-by: <wqu@xxxxxxxx>

Thanks,
Qu

>  
>  4. Write the test commands, comment anything that's not obvious.
>  
> 

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux