Re: [PATCH] btrfs-progs: dump_tree: remove superfluous _TREE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2017年11月25日 04:26, Hans van Kranenburg wrote:
> -# btrfs inspect-internal dump-tree -t fs /dev/block/device
> ERROR: unrecognized tree id: fs
> 
> Without this fix I can't dump-tree fs, but I can dump-tree fs_tree and
> also fs_tree_tree, which is a bit silly.
> ---
>  cmds-inspect-dump-tree.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/cmds-inspect-dump-tree.c b/cmds-inspect-dump-tree.c
> index 4e72c08a..df44bb63 100644
> --- a/cmds-inspect-dump-tree.c
> +++ b/cmds-inspect-dump-tree.c
> @@ -143,7 +143,7 @@ static u64 treeid_from_string(const char *str, const char **end)
>  		{ "CHUNK", BTRFS_CHUNK_TREE_OBJECTID },
>  		{ "DEVICE", BTRFS_DEV_TREE_OBJECTID },
>  		{ "DEV", BTRFS_DEV_TREE_OBJECTID },
> -		{ "FS_TREE", BTRFS_FS_TREE_OBJECTID },
> +		{ "FS", BTRFS_FS_TREE_OBJECTID },

Considering no other name has the _tree suffix, this looks good to me.

Reviewed-by: Qu Wenruo <wqu@xxxxxxxx>

Thanks,
Qu
>  		{ "CSUM", BTRFS_CSUM_TREE_OBJECTID },
>  		{ "CHECKSUM", BTRFS_CSUM_TREE_OBJECTID },
>  		{ "QUOTA", BTRFS_QUOTA_TREE_OBJECTID },
> 

Attachment: signature.asc
Description: OpenPGP digital signature


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux