Re: [PATCH v2 1/3] btrfs-progs: check: report more specific info about invalid location

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 22.11.2017 04:17, Su Yue wrote:
> Previously, it was so useless to print message like
> "invalid location %d".
> 
> Let it print objectid and offset of dir_item too.
> Debug is easier now.
> 
> Suggested-by: Nikolay Borisov <nborisov@xxxxxxxx>
> Signed-off-by: Su Yue <suy.fnst@xxxxxxxxxxxxxx>


Reviewed-by: Nikolay Borisov <nborisov@xxxxxxxx>

> ---
> changelog:
> v2:
> 	Print unknown location type.
> ---
>  cmds-check.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/cmds-check.c b/cmds-check.c
> index a93ac2c88a38..416a7601bce1 100644
> --- a/cmds-check.c
> +++ b/cmds-check.c
> @@ -1635,8 +1635,9 @@ static int process_dir_item(struct extent_buffer *eb,
>  					  namebuf, len, filetype,
>  					  key->type, error);
>  		} else {
> -			fprintf(stderr, "invalid location in dir item %u\n",
> -				location.type);
> +			fprintf(stderr,
> +				"Unknown location type %d in DIR_ITEM[%llu %llu]\n",
> +				location.type, key->objectid, key->offset);
>  			add_inode_backref(inode_cache, BTRFS_MULTIPLE_OBJECTIDS,
>  					  key->objectid, key->offset, namebuf,
>  					  len, filetype, key->type, error);
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux