Re: bug? fstrim only trims unallocated space, not unused in bg's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 20, 2017 at 9:58 PM, Qu Wenruo <quwenruo.btrfs@xxxxxxx> wrote:
>
>
> On 2017年11月21日 12:49, Chris Murphy wrote:
>> On Mon, Nov 20, 2017 at 9:43 PM, Qu Wenruo <quwenruo.btrfs@xxxxxxx> wrote:
>>>
>>>
>>>>
>>>> Apply in addition to previous patch? Or apply to clean v4.14?
>>>
>>> On previous patch.
>>
>> Refuses to apply with or without previous patch.
>>
>> $ git apply -v ~/qufstrim3.patch
>> Checking patch fs/btrfs/extent-tree.c...
>> error: while searching for:
>>        int dev_ret = 0;
>>        int ret = 0;
>>
>>        /*
>>         * try to trim all FS space, our block group may start from non-zero.
>>         */
>>
>> error: patch failed: fs/btrfs/extent-tree.c:10972
>> error: fs/btrfs/extent-tree.c: patch does not apply
>>
>
> Please try this branch.
>
> It's just previous patch and diff merged together and applied on v4.14
> tag from torvalds.
>
> https://github.com/adam900710/linux/tree/tmp

# fstrim -v /
/: 38 GiB (40767586304 bytes) trimmed
# dmesg

..snip...
[   46.408792] BTRFS info (device nvme0n1p8): trimming btrfs, start=0
len=75161927680 minlen=512
[   46.408800] BTRFS info (device nvme0n1p8): bg start=140882477056
len=1073741824
[   46.433867] BTRFS info (device nvme0n1p8): trimming done

Attaching 'btrfs-debug -b /' to get an idea about the block groups present.



-- 
Chris Murphy
$ sudo ~/Applications/btrfs-debugfs -b /
block group offset   140882477056 len 1073741824 used  663564288 chunk_objectid 256 flags 1 usage 0.62
block group offset   141956218880 len 1073741824 used  774782976 chunk_objectid 256 flags 1 usage 0.72
block group offset   143029960704 len 1073741824 used  559759360 chunk_objectid 256 flags 1 usage 0.52
block group offset   144103702528 len 1073741824 used  719872000 chunk_objectid 256 flags 1 usage 0.67
block group offset   145177444352 len 1073741824 used  407699456 chunk_objectid 256 flags 1 usage 0.38
block group offset   146251186176 len 1073741824 used  446414848 chunk_objectid 256 flags 1 usage 0.42
block group offset   147324928000 len 1073741824 used  647254016 chunk_objectid 256 flags 1 usage 0.60
block group offset   148398669824 len 1073741824 used  695906304 chunk_objectid 256 flags 1 usage 0.65
block group offset   149472411648 len 1073741824 used  655175680 chunk_objectid 256 flags 1 usage 0.61
block group offset   150546153472 len 1073741824 used  700932096 chunk_objectid 256 flags 1 usage 0.65
block group offset   151619895296 len 1073741824 used  822620160 chunk_objectid 256 flags 1 usage 0.77
block group offset   152693637120 len 1073741824 used  787226624 chunk_objectid 256 flags 1 usage 0.73
block group offset   153767378944 len 1073741824 used  751927296 chunk_objectid 256 flags 1 usage 0.70
block group offset   155948417024 len 1073741824 used  611794944 chunk_objectid 256 flags 1 usage 0.57
block group offset   157022158848 len 1073741824 used  284831744 chunk_objectid 256 flags 1 usage 0.27
block group offset   158095900672 len 1073741824 used  176189440 chunk_objectid 256 flags 1 usage 0.16
block group offset   159169642496 len 1073741824 used  530092032 chunk_objectid 256 flags 1 usage 0.49
block group offset   161317126144 len 1073741824 used  957775872 chunk_objectid 256 flags 1 usage 0.89
block group offset   162390867968 len 1073741824 used  703913984 chunk_objectid 256 flags 1 usage 0.66
block group offset   163464609792 len 1073741824 used  159911936 chunk_objectid 256 flags 1 usage 0.15
block group offset   166685835264 len 1073741824 used  156217344 chunk_objectid 256 flags 1 usage 0.15
block group offset   167759577088 len 1073741824 used  120881152 chunk_objectid 256 flags 1 usage 0.11
block group offset   168833318912 len 1073741824 used  692060160 chunk_objectid 256 flags 1 usage 0.64
block group offset   169907060736 len 1073741824 used  428404736 chunk_objectid 256 flags 1 usage 0.40
block group offset   170980802560 len 1073741824 used  782372864 chunk_objectid 256 flags 1 usage 0.73
block group offset   172054544384 len 1073741824 used  533180416 chunk_objectid 256 flags 1 usage 0.50
block group offset   173128286208 len 1073741824 used  891572224 chunk_objectid 256 flags 1 usage 0.83
block group offset   177423253504 len 1073741824 used 1025331200 chunk_objectid 256 flags 1 usage 0.95
block group offset   179570737152 len 1073741824 used 1058926592 chunk_objectid 256 flags 1 usage 0.99
block group offset   180644478976 len 1073741824 used  291184640 chunk_objectid 256 flags 1 usage 0.27
total_free 14174478336 min_used 120881152 free_of_min_used 952860672 block_group_of_min_used 167759577088
balance block group (167759577088) can reduce the number of data block group
[chris@f27h ~]$ 


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux