Re: [PATCH 0/3] add_qgroup/update_qgroup/__qgroup_search cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 31, 2017 at 05:13:42PM +0800, Lu Fengqi wrote:
> Patch 1 just remove the redundant function add_qgroup.
> Patch 2 separate QGROUP_INFO/QGROUP_LIMIT/QGROUP_RELATION process from
> the update_qgroup.
> Patch 3 mainly the coding style adjustment.

This per-patch description is fine, and not always necessary if the
patch subjects and changelogs are sufficient. The cover letter could be
some overview what are the patches addressing.

> 
> Lu Fengqi (3):
>   btrfs-progs: qgroup: cleanup the redundant function add_qgroup
>   btrfs-progs: qgroup: split update_qgroup to reduce arguments

1 and 2 applied, the cleanups look very good, thanks.

>   btrfs-progs: qgroup: cleanup __qgroup_search, no functional change

Not applied, please see the comments.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux