On Tue, Oct 31, 2017 at 05:13:45PM +0800, Lu Fengqi wrote: > 1. Use goto instead of while (1) to reduce the level of indentation I'd rather avoid this goto pattern in new code, using while is ok. If the indentation depth becomes problem, then the inner code should be moved to a helper. > 2. Replace the if statement with the switch statement This is good. > 3. move the BTRFS_IOC_TREE_SEARCH ioctl error handler to __qgroup_search This one as well, but please make them into separate patches, the code is being moved and changed at the same time. This makes the review harder. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
