Re: [PATCH 2/4] btrfs: let variable required be declared inside the loop

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On  9.11.2017 17:45, Anand Jain wrote:
> A preparation patch to create the actual device open in a new function.
> 

Just say you are reducing the visibility of some variables to the loop.

> Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
> ---
>  fs/btrfs/volumes.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index ab2f349ee293..ea6e542cb09d 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -970,19 +970,20 @@ int btrfs_close_devices(struct btrfs_fs_devices *fs_devices)
>  static int __btrfs_open_devices(struct btrfs_fs_devices *fs_devices,
>  				fmode_t flags, void *holder)
>  {
> -	struct request_queue *q;
> -	struct block_device *bdev;
>  	struct list_head *head = &fs_devices->devices;
>  	struct btrfs_device *device;
>  	struct btrfs_device *latest_dev = NULL;
> -	struct buffer_head *bh;
> -	struct btrfs_super_block *disk_super;
> -	u64 devid;
>  	int ret = 0;
>  
>  	flags |= FMODE_EXCL;
>  
>  	list_for_each_entry(device, head, dev_list) {
> +		struct request_queue *q;
> +		struct block_device *bdev;
> +		struct buffer_head *bh;
> +		struct btrfs_super_block *disk_super;
> +		u64 devid;
> +
>  		if (device->bdev)
>  			continue;
>  		if (!device->name)
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux