Re: [PATCH 06/11] btrfs: document device locking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 06, 2017 at 10:32:48AM +0800, Anand Jain wrote:
> >> + * Lock nesting
> >> + * ------------
> >> + *
> >> + * uuid_mutex
> >> + *   volume_mutex
> 
> I think it should be nested like this, but as of now its not. Ref [1]
>   [1]
>   btrfs: move volume_mutex into the btrfs_rm_device()

Right, this violates the documented rules and I think that's because of
the ambiguous semantic of the uuid_mutex. Here we're using the "on a
mounted filesystem" part so we lock only in the context where this
applies. Again, once volume_mutex is gone, this will be fixed.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux