On 31.10.2017 04:11, Anand Jain wrote: > > > On 10/30/2017 10:39 PM, David Sterba wrote: >> On Fri, Oct 20, 2017 at 10:07:15PM +0800, Anand Jain wrote: >>> We aren't setting the FMODE_WRITE when initializing btrfs_device >>> structure and when calling blkdev_put, however we are setting it >>> only when calling blkdev_get_by_path(). >> >> But this still does not say why this is a problem worth fixing. Nikolay >> asked for it, and I would do the same, but why do we even have to ask >> for that? > > Here its just a cleanup of miss match of open mode and close modes.> And there isn't any problem that I noticed. Even if that's the case, please state that explicitly in your changelog and also put "No functional changes" if you expect it to not introduce any change in behavior. > > Thanks, Anand > > >> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#describe-your-changes >> >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
