Re: [PATCH] btrfs-progs: ins: fix arg order in print_inode_item()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2017/10/30 17:39, Qu Wenruo wrote:
> 
> 
> On 2017年10月30日 16:10, Misono, Tomohiro wrote:
>> In the print_inode_item(), the argument order of sequence and flags are
>> reversed:
>>
>> printf("... sequence %llu flags 0x%llx(%s)\n",
>> 				... 
>> 	       (unsigned long long)btrfs_inode_flags(eb,ii),
>>  	       (unsigned long long)btrfs_inode_sequence(eb, ii),
>> 				...)
>>
>> So, just fix it.
> 
> Not related to this patch, but considering you're going to enhance
> root_item creation, it's also a good idea to print such info like
> c/o/s/r time and parent/receive UUID.
> 
> More patches will never be a bad thing.

Actually parent/received UUID is printed if it exists but c/o/s/r time is not
(for ROOT_ITEM). So, I will send a patch.

Thanks,
Tomohiro 


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux