On 2017年10月30日 16:10, Misono, Tomohiro wrote:
> In the print_inode_item(), the argument order of sequence and flags are
> reversed:
>
> printf("... sequence %llu flags 0x%llx(%s)\n",
> ...
> (unsigned long long)btrfs_inode_flags(eb,ii),
> (unsigned long long)btrfs_inode_sequence(eb, ii),
> ...)
>
> So, just fix it.
Not related to this patch, but considering you're going to enhance
root_item creation, it's also a good idea to print such info like
c/o/s/r time and parent/receive UUID.
More patches will never be a bad thing.
Thanks,
Qu
>
> Signed-off-by: Tomohiro Misono <misono.tomohiro@xxxxxxxxxxxxxx>
> ---
> print-tree.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/print-tree.c b/print-tree.c
> index 3c585e3..8abd760 100644
> --- a/print-tree.c
> +++ b/print-tree.c
> @@ -896,8 +896,8 @@ static void print_inode_item(struct extent_buffer *eb,
> btrfs_inode_uid(eb, ii),
> btrfs_inode_gid(eb, ii),
> (unsigned long long)btrfs_inode_rdev(eb,ii),
> - (unsigned long long)btrfs_inode_flags(eb,ii),
> (unsigned long long)btrfs_inode_sequence(eb, ii),
> + (unsigned long long)btrfs_inode_flags(eb,ii),
> flags_str);
> print_timespec(eb, btrfs_inode_atime(ii), "\t\tatime ", "\n");
> print_timespec(eb, btrfs_inode_ctime(ii), "\t\tctime ", "\n");
>
Attachment:
signature.asc
Description: OpenPGP digital signature
