On 2017年10月28日 01:37, David Sterba wrote: > On Fri, Oct 27, 2017 at 03:29:28PM +0800, Qu Wenruo wrote: >> This patchset adds quota support, which means the result fs will have >> quota enabled by default, and its accounting is already consistent, no >> manually rescan or quota enable is needed. > > Great, thanks for working on that. I'm going to merge the preparatory > patches next. I'm not sure about the command line option, we might want > to design it in a similar way as -O/--features. As this is a runtime > feature (unlike the on-disk format features), a new option will be > needed, backed by some research what other mkfs.* tools use. OK, I'll reconsider the command line interface. Although I'm not pretty sure if other fs will has such design. > > The uuid_tree would at least use the btrfs_create_tree, but I don't > think we'd need to create it only on request, so quotas will be the only > option. > >> 2) Fill quota root with basic skeleton >> Only 3 items are really needed >> a) global quota status item >> b) quota info for 0/5 qgroup >> c) quota limit for 0/5 qgroup >> >> The content doesn't matter at all. > > How would --rootdir and quotas behave in that case? A related question > is what will be the semantics of rootdir+quotas+subvolume created at > mkfs time. Already considered! (Although not in test case) For current behavior, rootdir works fine, as we only use one subvolume (fs tree) and rescan is placed just after we filled fs tree. So, as you could try your self, it's completely fine. And the infrastructure I used in the helpers can easily handle the case where extra subvolume qgroups are used. Just pass insert_qgroup_items() with new qgroupid, then rescan will handle them all. Thanks, Qu > > We can certainly start with only quotas on the empty filesystem, but I'm > sure somebody will ask for the wild combination at some point.> -- > To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html >
Attachment:
signature.asc
Description: OpenPGP digital signature
