Re: [PATCH] btrfs-progs: when unable to find out fsid of a dev just skip

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 27, 2017 at 03:28:48PM +0800, Anand Jain wrote:
> %fi_args.num_devices provides number of devices excluding the
> seed device. So when looping through the device list for a
> given fsid, determine if the given device is a seed device
> by reading its superblock and then skip it if its a seed device.
> Reading of the superblock is done by the function dev_to_fsid()
> which can fail if the user is not root OR if the device has media
> errors as well. So skip the seed check altogether if we fail to
> know the device superblock and thus the fsid.
> 
> With this now we are able to view the btrfs fi usage when the
> device is bad.
> 
> Signed-off-by: Anand Jain <anand.jain@xxxxxxxxxx>
> cc: misono.tomohiro@xxxxxxxxxxxxxx
> Fixes:
>   btrfs-progs: fi: enable fi usage for filesystem top of seed device

Thanks, the misc-test/023 fails due to that on my machine, but not in
the CI. I'd like to keep the tree bisectable, so I'll merge the two
patches together.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux