Re: [PATCH] btrfs-progs: qgroup: show subvol path when qgroup show

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 18, 2017 at 11:36:21AM +0800, Lu Fengqi wrote:
> >> @@ -1140,7 +1249,8 @@ static int __qgroups_search(int fd, struct qgroup_lookup *qgroup_lookup)
> >>  					goto skip;
> >>  				add_qgroup(qgroup_lookup,
> >>  					   btrfs_search_header_offset(sh), 0,
> >> -					   0, 0, 0, 0, 0, 0, 0, 0, 0, bq, bq1);
> >> +					   0, 0, 0, 0, 0, 0, 0, 0, 0, bq, bq1,
> >> +					   NULL);
> >
> >Oh no, yet another argument, so it's 15 in total.
> 
> So many arguments are really hard to accept, I will rework this.

This could be done independent of this patch, but the cleaning up this
area is highly desired.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux