On Mon, Oct 16, 2017 at 04:29:56PM +0300, Nikolay Borisov wrote: > Currently btrfs' code uses a mix of opencoded sizes and defines from sizes.h. > Let's unifiy the code base to always use the symbolic constants. No functional > changes > > -#define BTRFS_DEFRAG_BATCH 1024 > +#define BTRFS_DEFRAG_BATCH SZ_1K This is a number, not a size, so the SZ_ constant is misleading > static int __btrfs_run_defrag_inode(struct btrfs_fs_info *fs_info, > struct inode_defrag *defrag) > diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c > index a7f79254ecca..553172271913 100644 > --- a/fs/btrfs/raid56.c > +++ b/fs/btrfs/raid56.c > @@ -58,7 +58,7 @@ > */ > #define RBIO_CACHE_READY_BIT 3 > > -#define RBIO_CACHE_SIZE 1024 > +#define RBIO_CACHE_SIZE SZ_1K Same here. The rest is ok. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
