On Tue, Sep 26, 2017 at 08:41:27AM +0000, Paul Jones wrote: > > -----Original Message----- > > From: linux-btrfs-owner@xxxxxxxxxxxxxxx [mailto:linux-btrfs- > > owner@xxxxxxxxxxxxxxx] On Behalf Of David Sterba > > Sent: Sunday, 24 September 2017 11:46 PM > > To: Liu Bo <bo.li.liu@xxxxxxxxxx> > > Cc: linux-btrfs@xxxxxxxxxxxxxxx > > Subject: Re: [PATCH 1/2] Btrfs: fix kernel oops while reading compressed > > data > > > > On Wed, Sep 20, 2017 at 05:50:18PM -0600, Liu Bo wrote: > > > The kernel oops happens at > > > > > > kernel BUG at fs/btrfs/extent_io.c:2104! > > > ... > > > RIP: clean_io_failure+0x263/0x2a0 [btrfs] > > > > > > It's showing that read-repair code is using an improper mirror index. > > > This is due to the fact that compression read's endio hasn't recorded > > > the failed mirror index in %cb->orig_bio. > > > > > > With this, btrfs's read-repair can work properly on reading compressed > > > data. > > > > > > Signed-off-by: Liu Bo <bo.li.liu@xxxxxxxxxx> > > > Reported-by: Paul Jones <paul@xxxxxxxxxxxxxxx> > > > > Reviewed-by: David Sterba <dsterba@xxxxxxxx> > > Tested-by: <paul@xxxxxxxxxxxxxxx> > For both patches. Thanks for testing. > I caused the same thing to happen again, this time by unplugging the > wrong hard drive. Applied the patches and problem (BUG_ON) is gone. > Should this also go to stable? Seems like a rather glaring problem to me. Yes it should and will be forwarded there once it's merged to Linus' tree. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
