Re: [PATCH 2/2] Btrfs: remove bio_flags which indicates a meta block of log-tree

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 21, 2017 at 03:50:00PM -0600, Liu Bo wrote:
> Since both committing transaction and writing log-tree are doing
> plugging on metadata IO, we can unify to use %sync_writers to benefit
> both cases, instead of checking bio_flags while writing meta blocks of
> log-tree.
> 
> This removes the bio_flags related stuff for writing log-tree.

I'm not sure if this preserves the intentions introduced in
de0022b9da616b95ea5, as it's meant to do the checksums synchronously
(without offloading to other threads), if it's for the tree-log. So now
it depends on the sync_writers count to do that, while with the bio flag
it was independent.

The sync_writers is per-inode, while the bio flag is from the
submit_bio hook, so it's per-context.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux